1 From a49717040ef65aad7d8567572a7e8a4dc5d5dd6d Mon Sep 17 00:00:00 2001
    2 From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali@kernel.org>
    3 Date: Wed, 2 Dec 2020 18:16:01 +0100
    4 Subject: [PATCH 1/7] PCI: pci-bridge-emul: Add description for class_revision
    5  field
    6 MIME-Version: 1.0
    7 Content-Type: text/plain; charset=UTF-8
    8 Content-Transfer-Encoding: 8bit
    9 
   10 The current assignment to the class_revision member
   11 
   12   class_revision |= cpu_to_le32(PCI_CLASS_BRIDGE_PCI << 16);
   13 
   14 can make the reader think that class is at high 16 bits of the member and
   15 revision at low 16 bits.
   16 
   17 In reality, class is at high 24 bits, but the class for PCI Bridge Normal
   18 Decode is PCI_CLASS_BRIDGE_PCI << 8.
   19 
   20 Change the assignment and add a comment to make this clearer.
   21 
   22 Signed-off-by: Pali Rohár <pali@kernel.org>
   23 Signed-off-by: Marek Behún <kabel@kernel.org>
   24 ---
   25  drivers/pci/pci-bridge-emul.c | 6 +++++-
   26  1 file changed, 5 insertions(+), 1 deletion(-)
   27 
   28 diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c
   29 index db97cddfc85e..a4af1a533d71 100644
   30 --- a/drivers/pci/pci-bridge-emul.c
   31 +++ b/drivers/pci/pci-bridge-emul.c
   32 @@ -265,7 +265,11 @@ int pci_bridge_emul_init(struct pci_bridge_emul *bridge,
   33  {
   34         BUILD_BUG_ON(sizeof(bridge->conf) != PCI_BRIDGE_CONF_END);
   35  
   36 -       bridge->conf.class_revision |= cpu_to_le32(PCI_CLASS_BRIDGE_PCI << 16);
   37 +       /*
   38 +        * class_revision: Class is high 24 bits and revision is low 8 bit of this member,
   39 +        * while class for PCI Bridge Normal Decode has the 24-bit value: PCI_CLASS_BRIDGE_PCI << 8
   40 +        */
   41 +       bridge->conf.class_revision |= cpu_to_le32((PCI_CLASS_BRIDGE_PCI << 8) << 8);
   42         bridge->conf.header_type = PCI_HEADER_TYPE_BRIDGE;
   43         bridge->conf.cache_line_size = 0x10;
   44         bridge->conf.status = cpu_to_le16(PCI_STATUS_CAP_LIST);
   45 -- 
   46 2.32.0
   47